Merge pull request #1089 from crazy-max/fix-registry-auth-ecr-false

preserve explicit ECR settings in registry-auth
chore: update generated content
2026-10-21 07:03:58 +08:00 · 2026-10-16 20:24:38 +02:00 · 2026-10-05 14:23:04 +02:00 · 2026-10-05 14:23:04 +02:00 · 2026-10-05 14:21:32 +02:00
6 changed files with 129 additions and 109 deletions
@@ -168,3 +168,23 @@ test('getAuthList masks registry-auth password when present', async () => {

  expect(stdoutWriteSpy.mock.calls.map(call => call[0]).join('')).toContain('::add-mask::groundcontrol');
 });
+
+// prettier-ignore
+test.each([
+  ['false', 'false'],
+  ['"false"', 'false'],
+  ['true', 'true'],
+  ['auto', 'auto'],
+  ['""', 'auto']
+])('getAuthList normalizes registry-auth ecr: %s', (ecr, expected) => {
+  const [auth] = getAuthList({
+    registry: '',
+    username: '',
+    password: '',
+    scope: '',
+    ecr: '',
+    logout: true,
+    registryAuth: `- registry: 012345678910.dkr.ecr.eu-west-3.amazonaws.com\n  username: AWS\n  password: token\n  ecr: ${ecr}\n`
+  });
+  expect(auth.ecr).toBe(expected);
+});
@@ -4591,7 +4591,7 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.

 The following npm packages may be included in this product:

- - brace-expansion@1.1.21
+ - brace-expansion@1.1.16
 - brace-expansion@2.0.3

 These packages each contain the following license:
@@ -62,7 +62,7 @@ export function getAuthList(inputs: Inputs): Array<Auth> {
        username: auth.username,
        password: auth.password,
        scope: auth.scope,
-        ecr: auth.ecr || 'auto',
+        ecr: String(auth.ecr ?? '') || 'auto',
        configDir: scopeToConfigDir(registry, auth.scope)
      };
    });
@@ -2762,12 +2762,12 @@ __metadata:
  linkType: hard

 "brace-expansion@npm:^1.1.7":
-  version: 1.1.21
-  resolution: "brace-expansion@npm:1.1.21"
+  version: 1.1.16
+  resolution: "brace-expansion@npm:1.1.16"
  dependencies:
    balanced-match: "npm:^1.0.0"
    concat-map: "npm:0.0.1"
-  checksum: 10/6c0ed34107cb3bd3f44c01d90ec8c01baa3ed75b7755617e2e5797b5908bbf20b313edf575612b200a783b84c7d1826aec2f7a2f03de9905bbfae5dc3dea6a95
+  checksum: 10/94498bead66c51536df5b7bf1b0a0e581a5b7f86888be10481d06920c4bd9d976e003b13a3d19fddc733f21a09d162ff72f90e18b2c9d062b15121e973d0e13b
  languageName: node
  linkType: hard
Author	SHA1	Message	Date
CrazyMax	d3b9cdfa58	Merge pull request #1089 from crazy-max/fix-registry-auth-ecr-false preserve explicit ECR settings in registry-auth	2026-10-16 20:24:38 +02:00
CrazyMax	a27b71b09c	chore: update generated content Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>	2026-10-05 14:23:04 +02:00
CrazyMax	2c873c3656	test: simplify registry-auth ECR regression coverage Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>	2026-10-05 14:23:04 +02:00
breken-ai	b4bb2a4ec0	keep registry-auth ecr: false instead of falling back to auto registry-auth is parsed as YAML, so `ecr: false` (unquoted) is the boolean false, and `auth.ecr \|\| 'auto'` turned it into 'auto'. For an ECR registry this runs the AWS SDK login with the given username and password as AWS access keys, instead of the plain docker login the user asked for. Only the quoted string "false" worked. Convert the value to a string and only default to 'auto' when it is missing or empty. Assisted-By: Claude Signed-off-by: breken-ai <312387581+breken-ai@users.noreply.github.com>	2026-10-05 14:21:32 +02:00